Fix devcontainer CI: drop stale yarn apt source#126
Closed
dev-milos wants to merge 2 commits into
Closed
Conversation
The base image (mcr.microsoft.com/devcontainers/ruby:1-3.3-bullseye) ships a yarn apt source whose signing key was rotated (NO_PUBKEY 62D54FD4003F6525), so apt-get update fails during the dev container build in CI. Remove that source before apt-get update; yarn is already installed in the base image. (Bumping the base image to bookworm does not help: it ships the same source.)
dev-milos
force-pushed
the
fix/devcontainer-bookworm
branch
from
4bff005 to
e339a05
Compare
dev-milos
changed the title
The postCreateCommand calls rake directly, which resolves the system rake (13.4.2) instead of the bundled one (Gemfile: 13.2.1), causing Gem::LoadError during dev container setup. Run rake through bundle exec.
Author
|
Note: flagged the remaining failure with the maintainer on Slack. This PR fixes two of the devcontainer-CI failures - the base image's stale yarn apt source (broke CI now gets through both and reaches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes so the dev container builds and sets up in CI again (
build_testwas failing).